provide an empty import method in the generated module #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During development, the inline module is meant to be passed C code to compile. For a release, it is replaced with a module that already has the code compiled, so its import is meant to do nothing. Future versions of perl are planned to throw errors if an undefined import method is given arguments, since this generally indicates a mistake. Provide an empty import method to explicitly ignore the arguments.
This was referenced Jul 23, 2023
shawnlaffan
added a commit
to shawnlaffan/biodiverse-utils
that referenced
this pull request
Oct 3, 2024
No functional changes from 1.10. This is purely because this is built using a patched Inline::Module. See ingydotnet/inline-module-pm#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development, the inline module is meant to be passed C code to compile. For a release, it is replaced with a module that already has the code compiled, so its import is meant to do nothing.
Future versions of perl are planned to throw errors if an undefined import method is given arguments, since this generally indicates a mistake.
Provide an empty import method to explicitly ignore the arguments.