You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Inline::MakeMaker requires the module’s version number to be exactly of the form #.##.
croak <<END unless $version =~ /^\d\.\d\d$/;
Invalid version '$version' for $name.
Must be of the form '#.##'. (For instance '1.23')
END
This is too restrictive to be used with some modules. Is there any reason this validation needs to be done at all? It is true there needs to be a version for the XS_VERSION_BOOTCHECK to work, but if the version number is invalid, then that will fail. So why does Inline itself need to validate the version number?
The text was updated successfully, but these errors were encountered:
Inline and Inline::MakeMaker both want the VERSION of the module
to match #.##, but this isn't convenient for developer releases with '_'.
(and previously, they disagreed on whether additional digits were allowed)
There doesn't seem to be any technical limitation on the underscore
numbers, so relax the regexes and update the error messages.
Fixesingydotnet#62
Inline::MakeMaker requires the module’s version number to be exactly of the form #.##.
This is too restrictive to be used with some modules. Is there any reason this validation needs to be done at all? It is true there needs to be a version for the XS_VERSION_BOOTCHECK to work, but if the version number is invalid, then that will fail. So why does Inline itself need to validate the version number?
The text was updated successfully, but these errors were encountered: