Fixes of innodb.mysqld_core_dump_without_buffer_pool* (facebook#1118)

Summary: - innodb.mysqld_core_dump_without_buffer_pool* MTR test cases expect core pattern to be simple 'core' and core files located in the var dir - `mysqld` is killed to dump a core using SIGSEGV Pull Request resolved: facebook#1118 Reviewed By: atish2196 Squash with D7827421 Differential Revision: D20746947 Pulled By: atish2196 fbshipit-source-id: 166439e
inikep · Aug 3, 2020 · d142ee0 · d142ee0
1 parent d5955c3
commit d142ee0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/mysql-test/suite/innodb/r/mysqld_core_dump_without_buffer_pool.result b/mysql-test/suite/innodb/r/mysqld_core_dump_without_buffer_pool.result
@@ -3,7 +3,7 @@
 # Get the full path name of the PID file
 # Expecting a "crash", but don't restart the server until it is told to
 # Expected max core size is 1300 MB
-# Perl: Sent a SIGABRT to mysqld to dump a core.
+# Perl: Sent a SIGSEGV to mysqld to dump a core.
 # Perl: OK! Found the core file and it's small!
 # Make server restart
 # Wait for server to be back online
diff --git a/mysql-test/suite/innodb/r/mysqld_core_dump_without_buffer_pool_dynamic.result b/mysql-test/suite/innodb/r/mysqld_core_dump_without_buffer_pool_dynamic.result
@@ -18,7 +18,7 @@ SELECT @@global.innodb_buffer_pool_in_core_file;
 # Get the full path name of the PID file
 # Expecting a "crash", but don't restart the server until it is told to
 # Expected max core size is 1300 MB
-# Perl: Sent a SIGABRT to mysqld to dump a core.
+# Perl: Sent a SIGSEGV to mysqld to dump a core.
 # Perl: OK! Found the core file and it's small!
 # Make server restart
 # Wait for server to be back online
diff --git a/mysql-test/suite/innodb/r/mysqld_core_dump_without_buffer_pool_with_resizing.result b/mysql-test/suite/innodb/r/mysqld_core_dump_without_buffer_pool_with_resizing.result
@@ -8,7 +8,7 @@ set global innodb_buffer_pool_size = 2048*1024*1024;
 # Get the full path name of the PID file
 # Expecting a "crash", but don't restart the server until it is told to
 # Expected max core size is 1600 MB
-# Perl: Sent a SIGABRT to mysqld to dump a core.
+# Perl: Sent a SIGSEGV to mysqld to dump a core.
 # Perl: OK! Found the core file and it's small!
 # Make server restart
 # Wait for server to be back online
diff --git a/sql/conn_handler/socket_connection.cc b/sql/conn_handler/socket_connection.cc
@@ -1073,7 +1073,7 @@ static bool handle_admin_socket(
       race conditions with acl_init
      */
     if (get_server_state() != SERVER_OPERATING) {
-      my_sleep(100*1000);
+      my_sleep(100 * 1000);
       continue;
     }
 #ifdef HAVE_POLL