Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export tree adapter types as namespace to support TS4.x #1313

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Oct 27, 2024

Exports the tree adapter types as a namespace, individually. This reintroduces typescript 4.x support, which we accidentally broke in a non-breaking release.

Fixes #1299

Before we merge this I need to double check it really does fix the problem. I tried building it with 4.x and it works but I need to check the types are still the same

Exports the tree adapter types as a namespace, individually. This
reintroduces typescript 4.x support, which we accidentally broke in a
non-breaking release.
@43081j
Copy link
Collaborator Author

43081j commented Oct 28, 2024

seems to fix it so I'm going ahead and merging this 👀

@43081j 43081j merged commit c4a4eb7 into master Oct 28, 2024
11 checks passed
@43081j 43081j deleted the types-ts4 branch October 28, 2024 10:09
@wooorm
Copy link
Collaborator

wooorm commented Oct 28, 2024

If you want a review, I’d recommend keeping PRs open some non-weekend days too. I personally try not to work on the weekends. Some places (rust, node, unifiedjs) use a lazy consensus time of 72 hours.
That being said, if you don’t believe a review is needed, I’m fine with you merging immediately

@43081j
Copy link
Collaborator Author

43081j commented Oct 28, 2024

i wasn't planning on waiting for a review for this one unless someone happened to be around

i already tested that the types work as expected and discussed it somewhat on the TS discord, so figured its probably all good

will keep it in mind though, ive lost track of days a lot when travelling lately, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7.2.0 throws a TS error TS1383: Only named exports may use 'export type'
2 participants