fix(package): Allow deep imports from parse5
#453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `generate-parser-feedback-test` script currently fails due to deep imports from `parse5` not being allowed. I assume this will apply to all submodules that currently have deep imports. For now, let's allow deep imports of all files within `parse5`.
43081j
approved these changes
Mar 13, 2022
wooorm
reviewed
Mar 17, 2022
| }, | ||
| "./dist/*": { | ||
| "import": "./dist/*", | ||
| "require": "./dist/cjs/*" |
There was a problem hiding this comment.
I think that this is an anti-pattern.
The export map allows for an “allow-list” of what APIs to export as separate entry points, that is unrelated to the file system.
I believe we should carefully choose to expose what we want folks to use instead of exposing the whole file system?
Perhaps the problem in that script can be solved in a different way?
jmbpwtw
pushed a commit
to jmbpwtw/parse5
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
generate-parser-feedback-testscript currently fails due to deep imports fromparse5not being allowed. I assume this will apply to all submodules that currently have deep imports.For now, let's allow deep imports of all files within
parse5.