-
Notifications
You must be signed in to change notification settings - Fork 0
feat(config): Set SlotCalculator config with CHAIN_NAME instead of verbose values
#148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f verbose values This makes it easier to configure the builder through setting the chain name, instead of setting each calculator configuration variable. Closes ENG-1372
This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the builder unrunnable for any other chain. is that intentional?
|
It's runnable for any chain that the slot calculator supports through |
|
this is a significant change to builder functionality that makes it impossible to run on custom nets. is that intentional? |
|
Yes this is intentional. We want to make the builder easier to configure. Restricting the builders to chains we have the values in constants for is one way to do so. |
|
cc @rswanson i'd like your ACK/NACK on this before we merge |
|
Alright, with the new bin-base version now having the constants is still an option, if the |

This makes it easier to configure the builder slot calculator through setting the chain name, instead of setting each slot calculator configuration variable.
Closes ENG-1372
@rswanson this will lets us load the slot calculator from the
CHAIN_NAMEenv var.This also updates signet dependencies because it's needed to use the latest
bin-base. No behavior change is expected.