Skip to content

Conversation

@dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Oct 23, 2025

This PR improves span usage in the Flashbots submit task for better tracking in groundcover and analytics.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott changed the title improve spans use in flashbots submit obs: improve spans use in flashbots submit Oct 23, 2025
@dylanlott dylanlott force-pushed the dylan/flashbots-span branch from 45f8e09 to 8951b43 Compare October 23, 2025 18:00
@dylanlott dylanlott marked this pull request as ready for review October 23, 2025 18:20
@dylanlott dylanlott requested a review from Evalir as a code owner October 23, 2025 18:20
});
let bundle = match result {
Ok(bundle) => bundle,
Err(_) => continue,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be further simplified with:

let bundle = match self.prepare(&sim_result)
    .instrument(span.clone())
    .await
    .inspect_err(|error| {
        counter!("signet.builder.flashbots.bundle_prep_failures").increment(1);
        span_debug!(span, %error, "bundle preparation failed");
    }) {
    Ok(bundle) => bundle,
    Err(_) => continue,
};

Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whenever you're happy :)

@dylanlott dylanlott merged commit 4d6aee1 into main Oct 31, 2025
7 checks passed
@dylanlott dylanlott deleted the dylan/flashbots-span branch October 31, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants