feat: filter confirmed transactions from the block #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
requested review from
Evalir,
dylanlott and
prestwich
as code owners
prestwich
reviewed
Dec 11, 2024
Evalir
reviewed
Dec 11, 2024
dylanlott
reviewed
Dec 12, 2024
dylanlott
approved these changes
Dec 12, 2024
prestwich
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensures that transactions which have already confirmed on the rollup are not included in the block
does not include removal of the "seen_txns" cache in the TxPoller class. going to make a separate PR for that