Skip to content

Conversation

@dylanlott
Copy link
Contributor

  • bump alloy up
  • remove alloy primitives and import primitives from alloy core instead
  • fix errors from alloy updates
  • remove signet-types and reference zenith-types instead

@dylanlott dylanlott marked this pull request as ready for review January 10, 2025 19:14
Copy link
Contributor Author

dylanlott commented Jan 10, 2025

- bump alloy up
- remove alloy primitives and import primitives from alloy core instead
- fix errors from alloy updates
- remove signet-types and reference zenith-types instead
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit:

@dylanlott dylanlott force-pushed the dylan/bump-alloy-zenith branch from aedbf4d to 3b0c97b Compare January 10, 2025 19:49
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. just some last few nits. also, commits are still unverified, for some reason

use std::time::{Duration, Instant};
//! Bundler service responsible for managing bundles.
use super::oauth::Authenticator;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the blank line

use reqwest::Url;
use serde::{Deserialize, Serialize};
use signet_types::SignetEthBundle;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@@ -1,9 +1,9 @@
mod tests {
use std::str::FromStr;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@dylanlott dylanlott merged commit 6d53728 into main Jan 10, 2025
5 checks passed
@dylanlott dylanlott deleted the dylan/bump-alloy-zenith branch January 10, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants