-
Notifications
You must be signed in to change notification settings - Fork 0
feat: collect metrics on submitBlock transaction revert/success #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| pub mod block; | ||
| pub mod bundler; | ||
| pub mod oauth; | ||
| pub mod receipts; | ||
| pub mod submit; | ||
| pub mod tx_poller; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| use crate::config::Provider; | ||
| use alloy::{primitives::TxHash, providers::Provider as _}; | ||
| use metrics::{counter, histogram}; | ||
| use std::time::Instant; | ||
| use tokio::{sync::mpsc, task::JoinHandle}; | ||
| use tracing::{debug, error}; | ||
|
|
||
| /// Submits sidecars in ethereum txns to mainnet ethereum | ||
anna-carroll marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| #[derive(Debug, Clone)] | ||
| pub struct ReceiptTask { | ||
| /// Ethereum Provider | ||
| pub host_provider: Provider, | ||
| } | ||
|
|
||
| impl ReceiptTask { | ||
| pub async fn log_tx(&self, pending_tx_hash: TxHash) { | ||
anna-carroll marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| // start timer when tx hash is received | ||
| let start: Instant = Instant::now(); | ||
|
|
||
| // wait for the tx to mine, get its receipt | ||
| let receipt = self.host_provider.clone().get_transaction_receipt(pending_tx_hash).await; | ||
|
|
||
| match receipt { | ||
| Ok(receipt) => { | ||
anna-carroll marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| match receipt { | ||
anna-carroll marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| Some(receipt) => { | ||
| // record how long it took to mine the transaction | ||
| // potential improvement: use the block timestamp to calculate the time elapsed | ||
| histogram!("receipts.tx_mine_time") | ||
| .record(start.elapsed().as_millis() as f64); | ||
|
|
||
| // log whether the transaction reverted | ||
| if receipt.status() { | ||
| counter!("receipts.tx_reverted").increment(1); | ||
| debug!(tx_hash = %pending_tx_hash, "tx reverted"); | ||
| } else { | ||
| counter!("receipts.tx_succeeded").increment(1); | ||
| debug!(tx_hash = %pending_tx_hash, "tx succeeded"); | ||
| } | ||
| } | ||
| None => { | ||
| counter!("receipts.no_receipt").increment(1); | ||
| error!("no receipt found for tx hash"); | ||
| } | ||
| } | ||
| } | ||
| Err(e) => { | ||
| counter!("receipts.rpc_error").increment(1); | ||
| error!(error = ?e, "rpc error"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Spawns the task which collects metrics on pending transactions | ||
| pub fn spawn(self) -> (mpsc::UnboundedSender<TxHash>, JoinHandle<()>) { | ||
| let (sender, mut inbound) = mpsc::unbounded_channel(); | ||
| let handle = tokio::spawn(async move { | ||
| loop { | ||
| if let Some(pending_tx_hash) = inbound.recv().await { | ||
| let this = self.clone(); | ||
| tokio::spawn(async move { | ||
| let that = this.clone(); | ||
| that.log_tx(pending_tx_hash).await; | ||
| }); | ||
| } else { | ||
anna-carroll marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| tracing::debug!("upstream task gone"); | ||
| break; | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| (sender, handle) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.