chore: use bin base #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Feb 18, 2025
|
|
||
| tracing::trace!("installing metrics collector"); | ||
| PrometheusBuilder::new().install().expect("failed to install prometheus exporter"); | ||
| init4(); |
Member
Author
|
dont merge yet still migrating some stuff |
Member
|
all good the author always merges, home rule |
Evalir
approved these changes
Feb 18, 2025
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
could we add a description to the PR that tells what this is for? for posterity, since there are a lot of somewhat unrelated changes :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
init4()to set up metrics and tracingbring crate in line with clippy and code standards policies in other repos