Skip to content

add host sim #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 5, 2025
Merged

add host sim #132

merged 14 commits into from
Nov 5, 2025

Conversation

@prestwich
Copy link
Member

@prestwich prestwich commented Oct 30, 2025 •
edited
Loading

This PR does a few things and includes more drive-bys than it should

  1. Change the bundle driver to simulate the host transactions that it includes and update a cached host EVM
  2. Refactor the bundle drive to make the output accumulation more explicit
  3. Refactor fills/output propagation through the simulation environment
  4. Improve the OrderDetector to allow it to identify fills on both host and rollup
  5. Greatly improve simulator test scaffolding
  6. Create env objects for use in the simulator, to better encapsulate host/rollup EVM creation and configuration
  7. add many missing accessors
  8. handle 0-score bundles (by dropping them, previously this would cause a simulation loop until deadline)

@prestwich prestwich marked this pull request as ready for review October 30, 2025 17:45
@prestwich prestwich requested a review from a team as a code owner October 30, 2025 17:45
@prestwich Graphite App
Copy link
Member Author

prestwich commented Oct 30, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich prestwich mentioned this pull request Oct 30, 2025
Merged
@prestwich prestwich changed the base branch from prestwich/fill-builder to graphite-base/132 October 30, 2025 18:15
@prestwich prestwich force-pushed the prestwich/host-sim-wip branch from 579a7a3 to a853470 Compare October 30, 2025 18:15
@prestwich prestwich changed the base branch from graphite-base/132 to prestwich/remove-host-fills October 30, 2025 18:15
@prestwich prestwich mentioned this pull request Oct 30, 2025
Merged
@prestwich prestwich force-pushed the prestwich/host-sim-wip branch from a853470 to 19236a0 Compare October 30, 2025 18:36
@prestwich prestwich changed the base branch from prestwich/remove-host-fills to graphite-base/132 October 30, 2025 20:02
@prestwich prestwich force-pushed the prestwich/host-sim-wip branch from 554d991 to 01d39a5 Compare October 30, 2025 20:06
@prestwich prestwich changed the base branch from graphite-base/132 to prestwich/remove-host-fills October 30, 2025 20:06
Evalir
Evalir reviewed Oct 31, 2025
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid so far, few qs

crates/sim/src/env/sim_env.rs
Comment on lines +209 to +223
// This is redundant with the driver, however, we double check here.
// If perf is hit too much we can remove.
self.rollup
.fill_state()
.check_ru_tx_events(&outputs.bundle_fills, &outputs.bundle_orders)?;
Copy link
Member

@Evalir Evalir Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why double check? genuine question, want to understand the reasoning

Copy link
Member Author

@prestwich prestwich Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? maybe i did it wrong the first time lol

@prestwich prestwich changed the base branch from prestwich/remove-host-fills to graphite-base/132 November 3, 2025 18:45
@prestwich prestwich changed the base branch from graphite-base/132 to main November 3, 2025 18:45
@prestwich prestwich force-pushed the prestwich/host-sim-wip branch 2 times, most recently from 26ccfb3 to 9ca5e32 Compare November 3, 2025 18:47
@prestwich prestwich changed the title wip: add host sim add host sim Nov 4, 2025
@prestwich prestwich force-pushed the prestwich/host-sim-wip branch from 5e8de00 to f963913 Compare November 4, 2025 17:30
@prestwich prestwich force-pushed the prestwich/host-sim-wip branch from f963913 to 5a5c524 Compare November 4, 2025 17:30
@prestwich prestwich force-pushed the prestwich/host-sim-wip branch from 5a5c524 to b64aaee Compare November 4, 2025 17:36
@prestwich prestwich mentioned this pull request Nov 4, 2025
Merged
Evalir
Evalir approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's send it

@prestwich prestwich merged commit 871239a into main Nov 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evalir Evalir Evalir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prestwich @Evalir