Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable gas checks #54

Merged
merged 3 commits into from
Sep 19, 2024
Merged

feat: disable gas checks #54

merged 3 commits into from
Sep 19, 2024

Conversation

prestwich
Copy link
Contributor

@prestwich prestwich commented Sep 18, 2024

Add a Cfg implementation that disables all disable-able gas checks

@prestwich prestwich marked this pull request as ready for review September 18, 2024 19:21
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

*data = zenith_types::mintCall { amount: self.amount(), to: self.rollupRecipient }
.abi_encode()
.into();
*nonce = None;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd also add the nonce validation comment that exists in the above Tx impl

@prestwich prestwich changed the base branch from prestwich/journal to main September 18, 2024 19:57
@prestwich prestwich merged commit ed9940d into main Sep 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants