-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing msg registeration #108
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes introduce new data structures and methods to manage denomination pairs within the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API
participant OracleService
User->>API: Request to update oracle config
API->>OracleService: Call UpdateOracleConfig
OracleService-->>API: Return response
API-->>User: Return update status
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
==========================================
+ Coverage 47.89% 48.12% +0.23%
==========================================
Files 57 57
Lines 4270 4272 +2
==========================================
+ Hits 2045 2056 +11
+ Misses 1798 1788 -10
- Partials 427 428 +1
|
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
DenomPair
, for managing currency pairs.UpdateOracleConfig
RPC method.Bug Fixes
MsgFinalizeTokenWithdrawal
for clarity:sender
tofrom
andreceiver
toto
.Tests
MsgUpdateOracleConfig
message to ensure proper handling of valid and invalid inputs.