Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing msg registeration #108

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: add missing msg registeration #108

merged 1 commit into from
Sep 12, 2024

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Sep 12, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Introduced a new data structure, DenomPair, for managing currency pairs.
    • Added functionality to update oracle configurations via the UpdateOracleConfig RPC method.
  • Bug Fixes

    • Renamed fields in MsgFinalizeTokenWithdrawal for clarity: sender to from and receiver to to.
  • Tests

    • Added validation tests for the MsgUpdateOracleConfig message to ensure proper handling of valid and invalid inputs.

@beer-1 beer-1 self-assigned this Sep 12, 2024
@beer-1 beer-1 requested a review from a team as a code owner September 12, 2024 07:08
Copy link

coderabbitai bot commented Sep 12, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce new data structures and methods to manage denomination pairs within the GenesisState, enhance the token withdrawal message by renaming fields for clarity, and add a new RPC handler for updating oracle configurations. Additionally, a new message type for updating oracle configurations is registered in the codec, and corresponding tests are implemented to validate the new functionality. Overall, these modifications aim to improve data handling and clarity in the API.

Changes

Files Change Summary
api/opinit/opchild/v1/genesis.pulsar.go Added _GenesisState_8_list for managing DenomPair pointers and updated GenesisState struct with DenomPairs.
api/opinit/opchild/v1/types.pulsar.go Introduced DenomPair struct with methods for managing denomination pairs and updated file structure.
api/opinit/ophost/v1/tx.pulsar.go Renamed fields in MsgFinalizeTokenWithdrawal from sender and receiver to from and to.
proto/opinit/ophost/v1/tx.proto Added UpdateOracleConfig RPC handler for MsgUpdateOracleConfig.
x/ophost/types/codec.go Registered MsgUpdateOracleConfig in legacy codec and interface registry.
x/ophost/types/tx_test.go Introduced Test_MsgUpdateOracleConfig to validate message creation and input handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant API
    participant OracleService

    User->>API: Request to update oracle config
    API->>OracleService: Call UpdateOracleConfig
    OracleService-->>API: Return response
    API-->>User: Return update status
Loading

🐰 In the meadow, changes bloom,
New pairs of denoms find their room.
From sender to from, clarity reigns,
Oracles updated, no more chains.
With tests to ensure all's well and bright,
Hop along, all feels just right! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beer-1 beer-1 merged commit 0024749 into main Sep 12, 2024
4 of 5 checks passed
@beer-1 beer-1 deleted the fix/add-missing-config branch September 12, 2024 07:09
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.12%. Comparing base (f952aa4) to head (bfc5634).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
x/ophost/types/codec.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   47.89%   48.12%   +0.23%     
==========================================
  Files          57       57              
  Lines        4270     4272       +2     
==========================================
+ Hits         2045     2056      +11     
+ Misses       1798     1788      -10     
- Partials      427      428       +1     
Files with missing lines Coverage Δ
x/ophost/types/codec.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant