fix: improve error handling in VerifyAddressLen and Close functions

[SashaMalysehko]

This PR:

Enhances the VerifyAddressLen function:

Added detailed error messages that display the actual and expected address lengths.
Improved the debugging experience by providing more context in error cases.
Improves the Close function:

Added a nil check for BaseApp before closing to avoid potential panics.
Enhanced error messages by wrapping them properly with fmt.Errorf.
Added more descriptive error context for failures related to BaseApp and oracle client operations.

These changes improve:

Error debugging and troubleshooting.
Code robustness with additional nil checks.
Error message clarity for developers.

Testing:

All existing tests pass.
Manual testing of error scenarios has been performed.

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces improvements to error handling in the InitiaApp struct within the app/app.go file. The changes focus on enhancing error messages for address length verification and application closure. The modifications provide more context when errors occur, specifically by wrapping errors with additional information about address lengths and closure operations.

Changes

File	Change Summary
app/app.go	- Updated VerifyAddressLen() to provide more detailed error messages about address length - Enhanced Close() method with improved nil checks and error wrapping for BaseApp and oracleClient closure

Poem

🐰 A Rabbit's Ode to Error Clarity 🐰

In lines of code, where errors hide,
With context wrapped and details wide,
Our app now speaks with wisdom clear,
No mystery lurks, no message drear,
Debugging dance, a rabbit's delight! 🕺

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84ad50b and a3d9a45.

📒 Files selected for processing (1)

• app/app.go (2 hunks)

🔇 Additional comments (3)

app/app.go (3)

511-511: Enhanced error messaging for address length verification looks solid.
This improved context ("address length must be 20 or X bytes, got Y bytes") makes debugging easier.

---

568-571: Good practice to check for nil before closing BaseApp.
This prevents potential panics when BaseApp is unexpectedly nil.

---

577-577: Properly wrapping the oracle client stop error is a nice improvement.
Including descriptive context clarifies troubleshooting steps in failure scenarios.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.