Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint action and fix lint errors #53

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix lint action and fix lint errors #53

merged 2 commits into from
Jul 17, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Jul 17, 2024

@Vritra4 Vritra4 requested review from sh-cha and beer-1 July 17, 2024 07:54
@Vritra4 Vritra4 self-assigned this Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (af1c9a5) to head (66c3671).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   63.87%   63.84%   -0.03%     
==========================================
  Files          36       36              
  Lines        3125     3120       -5     
==========================================
- Hits         1996     1992       -4     
+ Misses        961      958       -3     
- Partials      168      170       +2     
Files Coverage Δ
app/test_helpers.go 79.54% <100.00%> (ø)
x/tokenfactory/client/cli/tx.go 0.00% <ø> (ø)
x/tokenfactory/keeper/createdenom.go 80.88% <100.00%> (-0.28%) ⬇️
x/tokenfactory/keeper/before_send.go 76.66% <50.00%> (+0.32%) ⬆️
app/app.go 82.41% <0.00%> (-0.21%) ⬇️
x/tokenfactory/keeper/genesis.go 67.56% <33.33%> (-3.87%) ⬇️
x/tokenfactory/keeper/creators.go 18.18% <0.00%> (-4.05%) ⬇️

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 3af55a1 into main Jul 17, 2024
5 of 6 checks passed
@beer-1 beer-1 deleted the chore/action-lint-fix branch July 17, 2024 09:04
hallazzang added a commit to milkyway-labs/milkyway that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants