-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump cometbft and use latest iavl & wasmd & wasmvm #88
Conversation
WalkthroughThis pull request involves updating dependency versions in both the Dockerfile and go.mod file. The changes primarily focus on upgrading the versions of libwasmvm and related dependencies, specifically updating Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🔇 Additional comments (3)Dockerfile (1)
The version update is consistent with the changes in go.mod. However, the commented hash verification lines should be updated with the correct hashes for v2.1.4 to ensure the integrity of the downloaded libraries. Run the following script to fetch and verify the hash values for v2.1.4: ✅ Verification successfulLet me try a different approach to verify the hashes. Let me try one more verification to get the official hashes from the release page. Let me try to fetch the checksums file specifically. Update hash verification with new checksums for v2.1.4 The commented hash verification lines in the Dockerfile should be updated with the following correct hashes for v2.1.4:
Update the commented lines to: RUN sha256sum /lib/libwasmvm_muslc.aarch64.a | grep 090b97641157fae1ae45e7ed368a1a8c091f3fef67958d3bc7c2fa7e7c54b6b4
RUN sha256sum /lib/libwasmvm_muslc.x86_64.a | grep a4a3d09b36fabb65b119d5ba23442c23694401fcbee4451fe6b7e22e325a4bac 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Fetch and display SHA256 hashes for libwasmvm v2.1.4 libraries
echo "Fetching hashes for libwasmvm v2.1.4 libraries..."
# Download and compute hashes for both architectures
curl -sL "https://github.com/CosmWasm/wasmvm/releases/download/v2.1.4/libwasmvm_muslc.x86_64.a" | sha256sum
curl -sL "https://github.com/CosmWasm/wasmvm/releases/download/v2.1.4/libwasmvm_muslc.aarch64.a" | sha256sum
# Note: Compare these hashes with the official release page
echo -e "\nVerify these hashes against: https://github.com/CosmWasm/wasmvm/releases/tag/v2.1.4"
Length of output: 708 Script: #!/bin/bash
# Let's check the Dockerfile to see if there are any commented hash verification lines
cat Dockerfile
Length of output: 2163 Script: #!/bin/bash
# Use GitHub CLI to fetch the release information
gh release view v2.1.4 --repo CosmWasm/wasmvm
Length of output: 510 Script: #!/bin/bash
# Download and display the checksums file
curl -sL "https://github.com/CosmWasm/wasmvm/releases/download/v2.1.4/checksums.txt"
Length of output: 613 go.mod (2)
The updates to wasmd and wasmvm versions are aligned with the PR objectives. The helpful comment about updating the Dockerfile ensures synchronization between the two files.
The cometbft replacement points to a specific commit. Ensure this commit is stable and contains the intended changes. Run the following script to verify the commit: 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
libwasmvm
to versionv2.1.4
.Bug Fixes
github.com/CosmWasm/wasmd
tov0.53.2
.github.com/CosmWasm/wasmvm/v2
tov2.1.4
.Chores
github.com/cosmos/iavl
.