Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test trigger. #152

Merged
merged 3 commits into from
Nov 18, 2024
Merged

test trigger. #152

merged 3 commits into from
Nov 18, 2024

Conversation

SeUkKim
Copy link
Collaborator

@SeUkKim SeUkKim commented Oct 23, 2024

Description

release triggered by a github action is not automatically triggering publish workflow.

  1. using published and created types. (this commit)
  2. using workflow_run.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Chores
    • Updated workflow configuration to trigger on workflow run events, enhancing automation for release management.
    • Improved consistency in step naming within the workflow.

@SeUkKim SeUkKim requested a review from a team as a code owner October 23, 2024 08:06
Copy link

coderabbitai bot commented Oct 23, 2024

Walkthrough

The pull request modifies the GitHub Actions workflow configuration in .github/workflows/publish.yml to change its triggering mechanism from release events to workflow run events. The on section now specifies workflow_run with a dependency on the "Release rust libmovevm" workflow, triggering on its completion. The job name has been updated to "Copy files to move-natives," and several step names have been capitalized for consistency. The commit message format for pushing files has also been adjusted to reflect the new context.

Changes

File Change Summary
.github/workflows/publish.yml Changed trigger from release events to workflow_run on completion of "Release rust libmovevm"; updated job name to "Copy files to move-natives"; capitalized step names; modified commit message format for pushing files.

Possibly related PRs

  • add github actions to publish. #137: This PR introduces a new GitHub Actions workflow in the same file (.github/workflows/publish.yml) and is directly related to the automation of the publishing process, which is also the focus of the main PR's changes.

Suggested reviewers

  • beer-1
  • Vritra4

Poem

In the land of code where rabbits play,
A workflow's triggered in a brand new way.
When rust libmovevm's release is done,
Our job hops in swiftly, oh what fun!
With capitalized steps and messages bright,
We celebrate changes, all day and night! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8ff6cc5 and 9118ee7.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/publish.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7bfd86c and 3421ec7.

📒 Files selected for processing (1)
  • .github/workflows/publish.yml (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
.github/workflows/publish.yml (2)

Line range hint 15-31: LGTM: First copy job is well-structured.

The job that copies precompile modules to move-natives is well-configured:

  • Uses explicit source paths
  • Proper authentication with PUBLISH_TOKEN
  • Clear commit message with release tag

Line range hint 32-50: LGTM: Second copy job is well-structured.

The job that copies shared libraries to builder.js is well-configured:

  • Uses explicit source paths
  • Proper authentication with PUBLISH_TOKEN
  • Clear destination directory specification
  • Clear commit message with release tag

.github/workflows/publish.yml Outdated Show resolved Hide resolved
Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 04bbbb9 into main Nov 18, 2024
3 of 4 checks passed
@beer-1 beer-1 deleted the feat/test-trigger branch November 18, 2024 04:18
@coderabbitai coderabbitai bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants