Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor feed events function #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: refactor feed events function #5

wants to merge 1 commit into from

Conversation

NguyenTuanCanh
Copy link

Improvements in Refactoring

  1. Readability: The refactored code uses intermediate variables like heightsToFetch and results, making the logic clearer and the code easier to read.
  2. Maintainability: By flattening the array directly within the loop and using clear logging, the code is more maintainable.
  3. Efficiency: The use of Promise.all for parallel fetching and Array.prototype.flat for flattening results enhances efficiency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NguyenTuanCanh