Use Enum for coloring options #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Stopak <jacob@initialcommit.io>
Also move some stray Enums into git-sim.enums.py. Enums have two advantages here, they: - show all options when using git-sim --help - help avoid typos in the string comparison in git_sim_base_command's color_by() function
|
@paketb0te Good to have you back! Since we have a few contributors now I created a |
|
... should have read the updated CONTRIBUTING.md 😆 |
|
@paketb0te Just making sure you saw my review comment above about keeping older syntax like |
|
@initialcommit-io huh, no I did not see your comment, and still can't find it - I am probably looking in the wrong place? Nevertheless I am of course changing that back immediately :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move some stray Enums into git-sim.enums.py.
Enums have two advantages here, they: