Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contract verify feature #125

Closed
5 of 7 tasks
codespool opened this issue Mar 9, 2023 · 3 comments · Fixed by #194 or #205
Closed
5 of 7 tasks

Add contract verify feature #125

codespool opened this issue Mar 9, 2023 · 3 comments · Fixed by #194 or #205
Assignees
Labels
enhancement New feature or request

Comments

@codespool
Copy link
Collaborator

codespool commented Mar 9, 2023

Overview (What and Why)

cargo-contract now supports verifiable builds, and we should add an option for it too:
https://use.ink/basics/contract-verification/

How

  • compile command with --verify (or similar flag) runs a build inside the parity-defined container
  • contract verify or similar command submits the deployed address and source files for verification

Definition of Done

  • production builds (with opt in/out verification) are running in the predefined container
  • new command for verification implemented
  • verification status check command implemented
  • above changes merged and released
  • docs updated

Open Issues and Blockers

  • for usage in swanky-dev-container, the docker-in-docker feature should be used, or some kind of parallel containers -> needs investigation
@andabak
Copy link
Collaborator

andabak commented Apr 17, 2023

Parity wants to standardize this process so lets understand this impact better before moving forward with this ticket. use-ink/cargo-contract#1065

@codespool codespool changed the title Production build and verify using Sirato Add contract verify feature Jul 5, 2023
@codespool codespool added this to the Grant proposal roadmap milestone Jul 5, 2023
@codespool codespool moved this from 💡 New/Idea to Proposed by Astar in Swanky Suite (legacy - moved to swankyhub) Jul 5, 2023
@HashWarlock
Copy link
Collaborator

We use this for our ink! validator function https://github.com/Phala-Network/ink-validator

@codespool
Copy link
Collaborator Author

We use this for our ink! validator function https://github.com/Phala-Network/ink-validator

Oh, nice! ..but what image does it use? I believe we should push the Parity's "official" image as a standard, since it's now published.

@TtomaS7 TtomaS7 moved this from Proposed by Astar to 🏗 In progress in Treasury Proposal Roadmap - ink!DevHub 1.0 Nov 20, 2023
@vsofiya vsofiya moved this from 🏗 In progress to 🛠 Ready for review in Treasury Proposal Roadmap - ink!DevHub 1.0 Jan 22, 2024
@vsofiya vsofiya moved this to 🛠 Ready for review in Treasury Proposal Roadmap - ink!DevHub 1.0 Jan 22, 2024
@prxgr4mm3r prxgr4mm3r linked a pull request Feb 7, 2024 that will close this issue
ipapandinas added a commit that referenced this issue Feb 12, 2024
Co-authored-by: Igor Papandinas <igor.papandinas@posteo.net>
@pmikolajczyk41 pmikolajczyk41 moved this from 🛠 Ready for review to Accepted in Treasury Proposal Roadmap - ink!DevHub 1.0 Feb 22, 2024
ipapandinas added a commit that referenced this issue Mar 25, 2024
Co-authored-by: Igor Papandinas <igor.papandinas@posteo.net>
ipapandinas added a commit that referenced this issue Mar 25, 2024
@ipapandinas ipapandinas moved this from Accepted to ✅ Done in Treasury Proposal Roadmap - ink!DevHub 1.0 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
5 participants