Skip to content

Conversation

@dimaMachina
Copy link
Collaborator

No description provided.

Copy link
Contributor

@sarah-inkeep sarah-inkeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think if there are xml tags in the prompt they are getting stripped out in the new editor:
Screenshot 2025-12-15 at 11 50 17 AM Screenshot 2025-12-15 at 11 58 57 AM
  1. I'm seeing an error about the $timestamp variable being unknown (this was in the inkeep-qa-graph.
Screenshot 2025-12-15 at 11 46 32 AM
  1. small nit but maybe we could only show the scroll boxes if the prompt is scrollable
Screenshot 2025-12-15 at 11 47 00 AM
  1. It seems like when the prompt editor is rendered it's marking the agent as unsaved even if I haven't made any changes.

@sarah-inkeep

This comment was marked as resolved.

@sarah-inkeep
Copy link
Contributor

sarah-inkeep commented Dec 15, 2025

also just noticed a few bugs with expand mode:

  1. if I click "Add variable" in the expand mode, it adds the curly bracket but I don't see the dropdown picker.
Screenshot 2025-12-15 at 12 27 54 PM
  1. If I try to add a variable after having been in the expand mode, nothing happens https://www.loom.com/share/9f48f6909df94dd28266d2943ef56140

I notice that the prompt in the fact-agent graph has backticks but I don't think they are intended to be rendered as code here since it is part of the instruction to the LLM to include backticks when providing code.
Screenshot 2025-12-15 at 11 46 17 AM

@dimaMachina dimaMachina marked this pull request as draft December 16, 2025 12:16
@dimaMachina
Copy link
Collaborator Author

Could we also set a maxHeight on the variables dropdown, I noticed it can sometimes overflow the page if there are a lot: Screenshot 2025-12-15 at 12 17 21 PM

yep, I finally found how to use shadcn dropdown and set max-h-64 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants