-
Notifications
You must be signed in to change notification settings - Fork 82
replace monaco-editor with TipTap editor for Prompt and Agent prompt inputs fields
#1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dimaMachina
wants to merge
94
commits into
main
Choose a base branch
from
prd-5263
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-inkeep
requested changes
Dec 15, 2025
Contributor
sarah-inkeep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think if there are xml tags in the prompt they are getting stripped out in the new editor:
- I'm seeing an error about the
$timestampvariable being unknown (this was in theinkeep-qa-graph.
- small nit but maybe we could only show the scroll boxes if the prompt is scrollable
- It seems like when the prompt editor is rendered it's marking the agent as unsaved even if I haven't made any changes.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
also just noticed a few bugs with expand mode:
I notice that the prompt in the fact-agent graph has backticks but I don't think they are intended to be rendered as code here since it is part of the instruction to the LLM to include backticks when providing code. |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



No description provided.