-
Notifications
You must be signed in to change notification settings - Fork 83
Bump agents-ui, remove the need to force refresh the widget when the … #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…headers change now that the widget is fixed
🦋 Changeset detectedLatest commit: 09933d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @sarah-inkeep's task —— View job PR Review: Bump agents-ui and Remove Widget Force Refresh LogicTodo List
SummaryThis PR removes a React performance anti-pattern (forced component remounting via dynamic Key Changes Analysis1. Force Refresh Logic Removal ✅ Good ChangeThe PR removes React Before: <InkeepSidebarChat
key={JSON.stringify(dynamicHeaders)} // ← Removed: Forced remount on header changes
// ... other props
/>
<ChatWidget
key={JSON.stringify(customHeaders)} // ← Removed: Forced remount on header changes
// ... other props
/>Why this is good:
2. Version Coordination ✅ Well ExecutedAll packages consistently updated to Architectural Review✅ Strengths
|
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Inkeep Agent Framework Docs' |
…headers change now that the widget is fixed