Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b754fba The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Claude encountered an error —— View job
Changes identified:
|
|
Claude finished @robert-inkeep's task in 3m 0s —— View job PR Review Summary3 Key Findings | Risk: High 🔴❗ Critical (1) ❗🔴🔴 1)
Issue: The PR updates the Why: Users will experience inconsistent behavior depending on which code path they hit:
Fix: Update all hardcoded references to use the constants: // init.ts line 168 - use resolved profile URL instead
const projectsUrl = `${resolvedProfile.remote.api}/manage/tenants/${selectedTenantId}/projects?limit=100`;
// init.ts line 456 - use LOCAL_REMOTE constant
import { LOCAL_REMOTE } from '../utils/profiles/types';
// ...
manageUi: LOCAL_REMOTE.manageUi,
// init.ts line 522 - use CLOUD_REMOTE constant
import { CLOUD_REMOTE } from '../utils/profiles/types';
// ...
url: CLOUD_REMOTE.api,
// login.ts lines 172-173 - use CLOUD_REMOTE constants
import { CLOUD_REMOTE } from '../utils/profiles/types';
// ...
manageApiUrl = CLOUD_REMOTE.api;
manageUiUrl = CLOUD_REMOTE.manageUi;
// ci-environment.ts line 86 - use CLOUD_REMOTE constant
agentsApiUrl: agentsApiUrl || CLOUD_REMOTE.api,🟠
|
| Location | Issue | Reason Excluded |
|---|---|---|
types.ts |
Port change from 3001→3000 | ✅ Verified correct - agents-manage-ui runs on port 3000 per package.json |
Discarded as invalid or not applicable
| Location | Issue | Reason Excluded |
|---|---|---|
agents-api/src/__tests__/ CORS tests |
May need URL updates | Tests already cover both old and new URL patterns |
| Documentation | May reference old URLs | No docs reference these URLs |
🚫 REQUEST CHANGES
Summary: This PR correctly updates the source-of-truth constants for cloud and local URLs, but the implementation is incomplete. There are 6 hardcoded URL references in source files and ~9 hardcoded test expectations that will not be updated, leading to split-brain behavior and immediate CI failures. The port change from 3001→3000 is verified correct. Please update all hardcoded references to use the constants (or update to new URLs) before merging.
The cloud URL constants were updated in #1752 but the profile config tests still expected the old URLs (agents-api.inkeep.com, manage.inkeep.com). Co-authored-by: Cursor <cursoragent@cursor.com>
) The cloud URL constants were updated in #1752 but the profile config tests still expected the old URLs (agents-api.inkeep.com, manage.inkeep.com). Co-authored-by: Cursor <cursoragent@cursor.com>
Bug: `inkeep init --local` hardcoded `manageUi: 'http://localhost:3001'` instead of importing the `LOCAL_REMOTE` constant (which was updated to port 3000 in PR #1752). The device-code auth flow sent users to the wrong port, causing ERR_CONNECTION_REFUSED for every new developer. Fix: - Import LOCAL_REMOTE in init.ts, replacing 4 hardcoded localhost URLs - Centralize fallback URLs in profile-config.ts and config.ts to use LOCAL_REMOTE instead of inline strings - Remove dead DEFAULT_LOCAL_PROFILE constant (never imported since creation in PR #1395) Additionally, split `profile add` into three remote type options: - Cloud: for Inkeep Cloud deployments (env defaults to 'production') - Local: for local dev (URLs from LOCAL_REMOTE, credential auto-set to 'none', no URL/credential prompts, env defaults to 'development') - Custom: for self-hosted/staging (placeholder hints, no pre-filled defaults, URL validation rejects empty input) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

No description provided.