feat(pr-review): Add missing documentation and changeset checks#1766
Closed
claude[bot] wants to merge 1 commit intomainfrom
Closed
feat(pr-review): Add missing documentation and changeset checks#1766claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
Learned from PR #1699 human reviewer feedback: 1. **Documentation Check (HIGH priority)** - pr-review-docs now checks if PR modifies user-facing code without docs - Triggers on: new UI components, API routes, schemas, package exports, SDK changes - Creates CRITICAL finding per AGENTS.md requirement - Human reviewer had to manually remind: "can you check for docs changes" 2. **Changeset Check (HIGH priority)** - pr-review-standards now checks if PR modifies published packages without changeset - Triggers on: agents-core, agents-api, agents-sdk, agents-manage-ui, agents-cli, etc. - Creates CRITICAL finding per AGENTS.md requirement - Human reviewer had to manually request: "can you write a changeset" 3. **React Compiler Annotation Fix (MEDIUM priority)** - pr-review-frontend now recognizes 'use memo' as valid React Compiler annotation - Bot incorrectly flagged this as invalid directive in PR #1699 - Human provided documentation link showing it's valid These patterns were identified through systematic analysis of human vs bot comments, meeting all 4 generalizability criteria: actionable, frequent, objectively verifiable, and not already covered.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Collaborator
|
Closing - PR body still too verbose (had extra sections). Updated agent with stricter template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the automated PR review system based on patterns identified from human reviewer feedback in PR #1699.
Changes
1. Documentation Check (HIGH priority - CRITICAL severity)
File:
.claude/agents/pr-review-docs.mdWhat it does:
*.tsxinagents-manage-ui/src/components/agents-api/src/domains/*/routes/*-schema.tsorpackages/agents-core/src/validation/package.jsonexports field changesagents-sdk/src/changesWhy this matters:
Example finding:
2. Changeset Check (HIGH priority - CRITICAL severity)
File:
.claude/agents/pr-review-standards.mdWhat it does:
agents-core,agents-api,agents-sdk,agents-manage-ui,agents-cli,create-agents,ai-sdk-providerWhy this matters:
Example finding:
3. React Compiler Annotation Fix (MEDIUM priority - Bug fix)
File:
.claude/agents/pr-review-frontend.mdWhat it does:
'use memo'and'use no memo'as valid React Compiler annotationsWhy this matters:
'use memo'as an invalid directiveMethodology
These improvements were identified through systematic analysis of PR #1699:
Result: 2 HIGH-generalizability patterns + 1 bug fix identified
Impact
Before this PR:
After this PR:
Testing Recommendation
To validate these changes work correctly:
agents-manage-ui/src/components/without docs → should trigger CRITICAL findingpackages/agents-core/without changeset → should trigger CRITICAL finding'use memo'directive → should NOT flag as errorRelated
closed-pr-review-auto-improver