Skip to content

fix max height for card content on traces conversation page #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shagun-singh-inkeep merged 7 commits into from
Feb 10, 2026
Merged

fix max height for card content on traces conversation page #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
610e898
local time for traces, end date when agent is done running
shagun-singh-inkeep Feb 10, 2026
7b184ff
changeset
shagun-singh-inkeep Feb 10, 2026
1655db0
lint and claude comment
shagun-singh-inkeep Feb 10, 2026
28a9537
remove unneeded state
shagun-singh-inkeep Feb 10, 2026
6939267
fix max height for card content
shagun-singh-inkeep Feb 10, 2026
1e7d2ee
chnageset
shagun-singh-inkeep Feb 10, 2026
4d086fa
Merge branch 'main' into TI-7
shagun-singh-inkeep Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/large-words-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@inkeep/agents-manage-ui": patch
---

fix max height for card content on traces conversation page
12 changes: 6 additions & 6 deletions ...ui/src/app/[tenantId]/projects/[projectId]/traces/conversations/[conversationId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export default function ConversationDetail({

return (
<Card
className="shadow-none bg-background"
className="shadow-none bg-background max-h-[280px] flex flex-col"
title={
conversation.conversationStartTime
? `Start: ${formatDateTime(conversation.conversationStartTime, { local: true })}${showEndTime && conversation.conversationEndTime ? `\nEnd: ${formatDateTime(conversation.conversationEndTime, { local: true })}` : ''}`
Expand Down Expand Up @@ -310,12 +310,12 @@ export default function ConversationDetail({
})()}

{/* AI Calls summary grouped by model */}
<Card className="shadow-none bg-background">
<CardHeader className="flex flex-row items-center justify-between space-y-0 pb-2">
<Card className="shadow-none bg-background max-h-[280px] flex flex-col">
<CardHeader className="flex flex-row items-center justify-between space-y-0 pb-2 flex-shrink-0">
<CardTitle className="text-sm font-medium text-foreground">AI Calls</CardTitle>
<MessageSquare className="h-4 w-4 text-muted-foreground" />
</CardHeader>
<CardContent>
<CardContent className="flex-1 min-h-0 overflow-y-auto">
Copy link
Contributor

@claude claude bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Consider: Scrollbar styling for consistency

Issue: This scrollable CardContent doesn't include the scrollbar styling classes used elsewhere in the traces components.

Why: The codebase has an established pattern of styled scrollbars (scrollbar-thin scrollbar-thumb-muted-foreground/30 scrollbar-track-transparent dark:scrollbar-thumb-muted-foreground/50) for a more refined look. Adding them here would match the pattern in activity-details-sidepane.tsx and tool-calls-by-server-card.tsx.

Fix: Consider adding scrollbar classes:

<CardContent className="flex-1 min-h-0 overflow-y-auto scrollbar-thin scrollbar-thumb-muted-foreground/30 scrollbar-track-transparent dark:scrollbar-thumb-muted-foreground/50">

Refs:

{(() => {
const ai = conversation?.activities?.filter(
(a: ActivityItem) =>
Expand Down Expand Up @@ -370,8 +370,8 @@ export default function ConversationDetail({
<MCPBreakdownCard conversation={conversation} />

{/* Alerts */}
<Card className="shadow-none bg-background">
<CardHeader className="flex flex-row items-center justify-between space-y-0 pb-2">
<Card className="shadow-none bg-background max-h-[280px] flex flex-col">
<CardHeader className="flex flex-row items-center justify-between space-y-0 pb-2 flex-shrink-0">
<CardTitle className="text-sm font-medium text-foreground">Alerts</CardTitle>
<TriangleAlert className="h-4 w-4 text-muted-foreground" />
</CardHeader>
Expand Down
2 changes: 1 addition & 1 deletion agents-manage-ui/src/components/traces/mcp-breakdown-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function MCPBreakdownCard({ conversation }: MCPBreakdownCardProps) {
}, [conversation]);

return (
<Card className="shadow-none bg-background flex flex-col">
<Card className="shadow-none bg-background flex flex-col max-h-[280px]">
<CardHeader className="flex flex-row items-center justify-between space-y-0 pb-2 flex-shrink-0">
<CardTitle className="text-sm font-medium text-foreground"> MCP Tool Calls</CardTitle>
<Wrench className="h-4 w-4 text-muted-foreground" />
Expand Down