feat(pr-review): sweep assessment framework + filtered diff metrics#1919
Merged
nick-inkeep merged 1 commit intomainfrom Feb 11, 2026
Merged
feat(pr-review): sweep assessment framework + filtered diff metrics#1919nick-inkeep merged 1 commit intomainfrom
nick-inkeep merged 1 commit intomainfrom
Conversation
… metrics - Add filtered additions/deletions/file count computed from git diff --numstat (respects EXCLUDE_PATTERNS, unlike raw GitHub API values that include lockfiles, snapshots, changelogs). Use these in the pr-context Size metadata row. - Add Sweep Assessment decision framework to pr-review orchestrator (Phase 1.1) with five qualitative factors: Size, Novelty, Sensitivity, Blast radius, Precedent. Replaces vague "very large surface area" language with a concrete, multi-dimensional evaluation that the orchestrator performs during re-reviews (review_scope=delta). - Update all three downstream references to point to the new framework. Co-authored-by: Cursor <cursoragent@cursor.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pr-contextSize row now reports additions/deletions/file counts computed fromgit diff --numstatwith the sameEXCLUDE_PATTERNSapplied to the diff. Previously these came from the GitHub API (unfiltered), which inflated counts with lockfiles, snapshots, changelogs, etc.review_scope=delta). Instead of the vague "very large surface area" heuristic, the orchestrator now evaluates five qualitative factors — Size, Novelty, Sensitivity, Blast radius, and Precedent — to decide whether a broader sweep beyond the delta is warranted. All three downstream references updated to point to the new framework.Files changed
.github/workflows/claude-code-review.ymlfiltered_additions,filtered_deletions,filtered_file_countfromgit diff --numstat(respectsEXCLUDE_PATTERNS). Use these in the pr-context Size metadata row instead of raw GitHub API values..claude/agents/pr-review.md### Sweep assessment (re-reviews only)subsection in Phase 1.1 with five-factor decision table and "two or more" threshold. Replace all three "very large surface area" references to point to the new framework.Test plan
review_scope=delta) on a large PR and verify the orchestrator performs the sweep assessment and notes its determinationMade with Cursor