Skip to content

Update toast error message for MCP tool connection #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimaMachina merged 1 commit into from
Feb 11, 2026
Merged

Update toast error message for MCP tool connection #1920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agents-manage-ui/src/app/[tenantId]/projects/[projectId]/agents/[agentId]/page.client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ export const Agent: FC<AgentProps> = ({
const targetNode = nodes.find((n) => n.id === params.target);
if (targetNode && targetNode.type === NodeType.MCP) {
if (edges.some((edge) => edge.target === targetNode.id)) {
toast.error('This MCP tool is already connected. Remove the existing connection first.');
toast.error('This MCP tool is already connected. Connect to a new MCP server node.');
Copy link
Contributor

@claude claude bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 CONSIDER: Completeness of user guidance

Issue: Both actions are valid — users can either remove the existing connection OR connect to a new MCP server node. The new message drops the first option.

Why: The old message guided users to the existing edge editor delete functionality, while the new message only mentions creating a new node. Users who want to re-wire an existing MCP node (rather than add another one) might be confused about how to proceed.

Fix: Consider whether to include both options, or whether the UX intent is to deliberately steer users toward adding new nodes:

toast.error('This MCP tool is already connected. Remove the existing connection first, or connect to a new MCP server node.');

Or keep the new message if the product intent is to encourage creating new MCP nodes over modifying existing connections.

return;
}
updateNodeData(targetNode.id, {
Expand Down