Remove dead buildAgentViewUrl utility#1984
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
🔴❗ Critical (0) ❗🔴
No critical issues.
🟠⚠️ Major (0) 🟠⚠️
No major issues.
🟡 Minor (0) 🟡
No minor issues.
💭 Consider (0) 💭
No suggestions.
✅ APPROVE
Summary: Clean dead code removal. Verified via grep that buildAgentViewUrl and normalizeBaseUrl have zero callers in the monorepo. The functionality was replaced by inline URL construction in push.ts:277. Neither function is exported from any barrel file or included in the package's public API. Tests pass. No changeset needed since this doesn't affect published package behavior. Ship it! 🚀
Discarded (0)
No findings discarded.
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-standards |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: Standards reviewer confirmed dead code verification — no issues found.
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta Re-Review Summary
This re-review was triggered by a pull_request:synchronize event. The delta since the last review consists of:
- 1 merge commit (
756bdefd) bringing in 41 commits fromorigin/main - 0 PR-specific changes — the actual deletions remain unchanged
Verification Performed
| Check | Result |
|---|---|
| Files still deleted | ✅ url.ts and url.test.ts confirmed absent |
| No new imports introduced | ✅ No production code references buildAgentViewUrl or normalizeBaseUrl |
| Merge conflicts | ✅ Clean merge, no conflicts |
| PR scope unchanged | ✅ Still +0/-146, 2 files deleted |
🔴❗ Critical (0) ❗🔴
No critical issues.
🟠⚠️ Major (0) 🟠⚠️
No major issues.
🟡 Minor (0) 🟡
No minor issues.
💭 Consider (0) 💭
No suggestions.
✅ APPROVE
Summary: Clean delta re-review. The PR's actual changes (dead code deletion of buildAgentViewUrl and normalizeBaseUrl) remain unchanged from the prior approval. The synchronize event was triggered by merging main into the feature branch — no new PR-specific code was introduced. Verified that no conflicting imports or regressions were introduced by the merge. Prior approval stands. 🎯
Discarded (0)
No findings discarded.
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: No sub-reviewers dispatched — delta contains no PR-specific code changes to review.
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta Re-Review Summary
This re-review was triggered by a pull_request:synchronize event. The delta since the last review consists of:
- 1 merge commit (
0be34941) bringing in 29 commits fromorigin/main - 0 PR-specific changes — the actual deletions remain unchanged
Verification Performed
| Check | Result |
|---|---|
| Files still deleted | ✅ url.ts and url.test.ts confirmed absent via glob |
| No new imports introduced | ✅ Grep confirms no production code references buildAgentViewUrl or normalizeBaseUrl |
| Merge conflicts | ✅ Clean merge, no conflicts |
| PR scope unchanged | ✅ Still +0/-146, 2 files deleted |
🔴❗ Critical (0) ❗🔴
No critical issues.
🟠⚠️ Major (0) 🟠⚠️
No major issues.
🟡 Minor (0) 🟡
No minor issues.
💭 Consider (0) 💭
No suggestions.
✅ APPROVE
Summary: Clean delta re-review. The PR's actual changes (dead code deletion of buildAgentViewUrl and normalizeBaseUrl) remain unchanged from the prior approval. The synchronize event was triggered by merging main into the feature branch — no new PR-specific code was introduced. Verified that no conflicting imports or regressions were introduced by the merge. Prior approval stands. 🧹✨
Discarded (0)
No findings discarded.
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: No sub-reviewers dispatched — delta contains no PR-specific code changes to review.
nick-inkeep
force-pushed
the
cleanup/remove-dead-buildAgentViewUrl
branch
from
0be3494 to
306c56f
Compare
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta Re-Review Summary
This re-review was triggered by a pull_request:synchronize event. The delta since the last review consists of:
- Merge commits only — bringing in changes from
origin/main - 0 PR-specific changes — the actual deletions (
url.tsandurl.test.ts) remain unchanged
Verification Performed
| Check | Result |
|---|---|
| Files still deleted | ✅ Glob confirms url.ts and url.test.ts are absent |
| No new imports introduced | ✅ Grep finds no production references to buildAgentViewUrl or normalizeBaseUrl (only hit is pr-context metadata) |
| Merge conflicts | ✅ Clean merge, no conflicts |
| PR scope unchanged | ✅ Still +0/-146, 2 files deleted |
🔴❗ Critical (0) ❗🔴
No critical issues.
🟠⚠️ Major (0) 🟠⚠️
No major issues.
🟡 Minor (0) 🟡
No minor issues.
💭 Consider (0) 💭
No suggestions.
✅ APPROVE
Summary: Clean delta re-review. The PR's changes (dead code deletion of buildAgentViewUrl and normalizeBaseUrl with their tests) remain unchanged from the prior 3 approvals. The synchronize event was triggered by merging main — no new PR-specific code was introduced. Verified that no conflicting imports or regressions were introduced by the merge. Prior approval stands.
Good hygiene keeping the codebase clean! 🧹✨
Discarded (0)
No findings discarded.
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: No sub-reviewers dispatched — this is a dead code deletion with zero callers, no customer-facing impact, and 3 prior approvals. Delta contains no PR-specific code changes to review.
Remove `agents-cli/src/utils/url.ts` and its test file. Both exported functions (`buildAgentViewUrl`, `normalizeBaseUrl`) have zero production callers anywhere in the monorepo. History: - Sep 2025 (PR #67, b27cd88): Created as `buildGraphViewUrl` by @andrewmikofalvy for use in `push.ts` to display agent view links in CLI output after pushing. - Oct 2025 (PR #564, ace6280): Renamed to `buildAgentViewUrl` during the Graph → Agent rename refactor. - Between then and now: The import was removed from `push.ts` during a subsequent refactor. `push.ts` now constructs URLs inline. The function and its 22 tests were left behind with no callers. Neither function is re-exported from any barrel file or the package's public API (package.json exports only `./dist/index.js` and `./config`). No other package in the monorepo imports them. Test suite: 610 pass, 5 skipped, 0 failures (39 files). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nick-inkeep
force-pushed
the
cleanup/remove-dead-buildAgentViewUrl
branch
from
306c56f to
ae64f21
Compare
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
Delta Re-Review Summary
This re-review was triggered by a pull_request:synchronize event. The delta since the last review consists of:
- Merge from main — bringing in recent commits from
origin/main - 0 PR-specific changes — the actual deletions remain unchanged
Verification Performed
| Check | Result |
|---|---|
| Files still deleted | ✅ Glob confirms url.ts and url.test.ts are absent |
| No new imports introduced | ✅ Grep finds no production references to buildAgentViewUrl or normalizeBaseUrl |
| Merge conflicts | ✅ Clean merge, no conflicts |
| PR scope unchanged | ✅ Still +0/-146, 2 files deleted |
🔴❗ Critical (0) ❗🔴
No critical issues.
🟠⚠️ Major (0) 🟠⚠️
No major issues.
🟡 Minor (0) 🟡
No minor issues.
💭 Consider (0) 💭
No suggestions.
✅ APPROVE
Summary: Clean delta re-review. The PR's changes (dead code deletion of buildAgentViewUrl and normalizeBaseUrl with their tests) remain unchanged from the prior 4 approvals. The synchronize event was triggered by a merge from main — no new PR-specific code was introduced. Verified that no conflicting imports or regressions were introduced. Prior approval stands.
Ship it and enjoy the 146-line weight loss! 🎯🧹
Discarded (0)
No findings discarded.
Reviewers (0)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
Note: No sub-reviewers dispatched — this is a dead code deletion with zero callers, no customer-facing impact, and 4 prior approvals. Delta contains no PR-specific code changes to review.
2 participants
Summary
agents-cli/src/utils/url.ts(2 exported functions:buildAgentViewUrl,normalizeBaseUrl)agents-cli/src/utils/__tests__/url.test.ts(22 tests)Both functions have zero production callers anywhere in the monorepo.
History
b27cd885c)buildGraphViewUrlfor use inpush.tsto display agent view links after pushingace62802a)buildAgentViewUrlduring the Graph → Agent rename refactorpush.ts.push.tsnow constructs URLs inline (line 277). The function and its tests were left behind with no callers.Why it's dead code
buildAgentViewUrl: grep across the entire monorepo finds zero imports outside its own definition and test filenormalizeBaseUrl: only caller isbuildAgentViewUrlitself (also dead)package.jsonexports only./dist/index.jsand./config)Test plan
pnpm test— 610 pass, 5 skipped, 0 failures (39 files)🤖 Generated with Claude Code