fix: eliminate flaky wall-clock timing in ready.test.ts parallelism check#2069
Merged
nick-inkeep merged 1 commit intomainfrom Feb 17, 2026
Merged
fix: eliminate flaky wall-clock timing in ready.test.ts parallelism check#2069nick-inkeep merged 1 commit intomainfrom
nick-inkeep merged 1 commit intomainfrom
Conversation
… check in ready.test.ts The "runs database checks in parallel" test used performance.now() with a hard 50ms ceiling that flaked under CPU pressure (observed 59.79ms). Replace with event-ordering assertions that prove both checks started before either finished — a deterministic proof of parallelism immune to machine load. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
performance.now()wall-clock assertions with event-ordering assertions in the "runs database checks in parallel" test< 50msceiling that flaked under CPU pressure (observed 59.79ms during pre-commit hook runs)start/endevents and asserts both checks started before either finished — a deterministic proof of parallelism immune to machine loadTest plan
ready.test.tspasses consistently (verified 5/5 runs locally)🤖 Generated with Claude Code