Skip to content

Slack allowed redirect fix #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert-inkeep merged 3 commits into from
Feb 17, 2026
Merged

Slack allowed redirect fix #2071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
393fdbb
just accept INKEEP_AGENTS_MANAGE_UI_URL
robert-inkeep Feb 17, 2026
65ecf80
changeset
robert-inkeep Feb 17, 2026
435de2d
Update .changeset/mighty-trains-teach.md
robert-inkeep Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-trains-teach.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@inkeep/agents-work-apps": patch
---

Remove hostname allowlist validation for INKEEP_AGENTS_MANAGE_UI_URL to support custom domains
25 changes: 0 additions & 25 deletions packages/agents-work-apps/src/slack/routes/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,32 +29,7 @@ const logger = getLogger('slack-oauth');

const STATE_TTL_MS = 10 * 60 * 1000;

/**
* Allowed redirect domains for OAuth callbacks.
* Validates INKEEP_AGENTS_MANAGE_UI_URL to prevent open redirect attacks.
*/
const ALLOWED_REDIRECT_HOSTNAMES = new Set(['localhost', '127.0.0.1', 'agents.inkeep.com']);

function isAllowedRedirectUrl(url: string): boolean {
try {
const parsed = new URL(url);
if (ALLOWED_REDIRECT_HOSTNAMES.has(parsed.hostname)) return true;
// Allow any *.inkeep.com subdomain
if (parsed.hostname.endsWith('.inkeep.com')) return true;
return false;
} catch {
return false;
}
}

// Validate at module load time so misconfig is caught early
const manageUiUrl = env.INKEEP_AGENTS_MANAGE_UI_URL || 'http://localhost:3000';
if (!isAllowedRedirectUrl(manageUiUrl)) {
throw new Error(
`Invalid INKEEP_AGENTS_MANAGE_UI_URL: "${manageUiUrl}" is not in the allowed redirect domains. ` +
'Allowed: localhost, 127.0.0.1, *.inkeep.com'
);
}

interface OAuthState {
nonce: string;
Expand Down
Loading