fix: increase Monaco waitFor timeout for CI reliability#2088
fix: increase Monaco waitFor timeout for CI reliability#2088nick-inkeep merged 1 commit intomainfrom
Conversation
The 20s waitFor timeout for Monaco editor initialization is insufficient on ubuntu-16gb runners when Turbo cache misses cause parallel build jobs to compete for resources. Bump to 30s (with 60s test timeout) to accommodate. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This PR makes a targeted, well-justified change to address CI flakiness on resource-constrained runners.
What Was Reviewed
- Test coverage (
pr-review-tests): Confirmed no test coverage gaps — this is a test reliability improvement, not code requiring tests - DevOps/Infrastructure (
pr-review-devops): Validated timeout adjustments are reasonable and consistent with existing patterns
Why This Change Is Appropriate
- Proportional timeout increase: The
waitFortimeout (20s → 30s) and test timeout (45s → 60s) maintain a consistent ~15s buffer for the screenshot assertion - Consistent with existing patterns: The vitest config already acknowledges Monaco requires extended timeouts on CI, and other browser tests use similar timeout values
- Clear root cause: The PR description documents the flakiness occurring specifically on
ubuntu-16gbrunners during Turbo cache misses when parallel jobs compete for resources - No side effects: No changes to CI workflows, dependencies, or infrastructure — purely test code adjustments
No Issues Found
Both specialized reviewers and the orchestrator's own analysis found no issues with this change.
✅ APPROVE
Summary: Clean, minimal fix for CI reliability. The timeout increases are justified by documented flakiness, proportional to each other, and consistent with existing patterns in the codebase. Ship it! 🚀
Reviewers (2)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-tests |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
pr-review-devops |
0 | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 | 0 | 0 | 0 |
1 participant
Summary
waitFortimeout from 20s to 30s for Monaco editor initialization in browser screenshot testsContext
PRs with Turbo cache misses on
ubuntu-16gbrunners cause parallel build/test jobs to compete for CPU/memory. Under this resource contention, Monaco editor's dynamic imports take longer than 20s to complete, causingwaitForto timeout before.monaco-editorappears in DOM.This was observed consistently (3/3 attempts) on PRs #2054, #2037, and #2033 after merging main. The
ubuntu-latestrunner passed every time.Test plan
ubuntu-16gbandubuntu-latestrunners🤖 Generated with Claude Code