Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,18 @@ jobs:
echo "Cleaning up any existing database files..."
find . -name "*.db" -o -name "*.sqlite" | grep -v node_modules | xargs -r rm -f

# Run all CI checks in parallel with Turborepo
# Build all packages first so heavy compilation doesn't compete with
# browser tests (Playwright + Monaco) for CPU on cache-miss runs.
- name: Build packages
run: pnpm turbo run build --filter='!agents-cookbook-templates'
env:
NODE_OPTIONS: --max-old-space-size=4096
CI: true
Comment on lines +112 to +114
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 Consider: Add ENVIRONMENT: test for cache key consistency

Issue: The "Build packages" step doesn't set ENVIRONMENT, while the "Run CI checks" step sets ENVIRONMENT: test. Since ENVIRONMENT is in Turbo's globalEnv (turbo.json:11), it affects cache key computation for all tasks.

Why: When the build step runs with ENVIRONMENT=undefined and the check step runs with ENVIRONMENT=test, Turbo computes different cache keys. This could cause the check step to miss the build cache and re-run builds, partially defeating the optimization goal.

Fix:

Suggested change
env:
NODE_OPTIONS: --max-old-space-size=4096
CI: true
env:
ENVIRONMENT: test
NODE_OPTIONS: --max-old-space-size=4096
CI: true

Refs:


# Run lint, typecheck, and test with builds already cached.
- name: Run CI checks
id: ci-check
run: |
# Run all checks in parallel using Turborepo's dependency graph
# This will build once and cache, then run lint, typecheck, and test in parallel
pnpm check
run: pnpm check
env:
ENVIRONMENT: test
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY || 'sk-test-key-for-ci-testing' }}
Expand Down