Skip to content

revert: undo CI split approach (#2092) #2093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nick-inkeep merged 1 commit into from
Feb 17, 2026
Merged

revert: undo CI split approach (#2092) #2093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,18 +105,13 @@ jobs:
echo "Cleaning up any existing database files..."
find . -name "*.db" -o -name "*.sqlite" | grep -v node_modules | xargs -r rm -f

# Build all packages first so heavy compilation doesn't compete with
# browser tests (Playwright + Monaco) for CPU on cache-miss runs.
- name: Build packages
run: pnpm turbo run build --filter='!agents-cookbook-templates'
env:
NODE_OPTIONS: --max-old-space-size=4096
CI: true

# Run lint, typecheck, and test with builds already cached.
# Run all CI checks in parallel with Turborepo
- name: Run CI checks
id: ci-check
run: pnpm check
run: |
# Run all checks in parallel using Turborepo's dependency graph
# This will build once and cache, then run lint, typecheck, and test in parallel
pnpm check
Comment on lines +108 to +114
Copy link
Contributor

@claude claude bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Minor: Comment slightly overstates parallelism

Issue: The comment states Turborepo will "run lint, typecheck, and test in parallel" after building. However, per turbo.json, lint (line 92) has no build dependency, typecheck (line 102) depends on ^build, and test (line 55) depends on build. On cache-miss runs, lint runs immediately while typecheck and test wait for their dependencies.

Why: The current comment could mislead someone debugging CI timing issues into thinking all checks run concurrently from the start.

Fix: (1-click apply)

Suggested change
# Run all CI checks in parallel with Turborepo
- name: Run CI checks
id: ci-check
run: pnpm check
run: |
# Run all checks in parallel using Turborepo's dependency graph
# This will build once and cache, then run lint, typecheck, and test in parallel
pnpm check
# Run all CI checks via Turborepo
- name: Run CI checks
id: ci-check
run: |
# Turborepo handles task dependencies: lint runs immediately,
# while typecheck and test wait for build to complete (cached when unchanged).
pnpm check

Refs:

env:
ENVIRONMENT: test
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY || 'sk-test-key-for-ci-testing' }}
Expand Down