-
Notifications
You must be signed in to change notification settings - Fork 101
Update azure-vm.mdx #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update azure-vm.mdx #2173
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Minor: Health probe host configuration may confuse users
Issue: The instruction to use
127.0.0.1as the host for the health probe, combined with setting "Pick host name from backend settings" to "No", may confuse users about how Azure Application Gateway probes work. Users might expect127.0.0.1means "probe from localhost" rather than understanding it sets the HTTP Host header while the probe actually targets the VM's private IP.Why: While this configuration likely works (the Inkeep API
/healthendpoint doesn't validate Host headers), the combination of settings is non-obvious and could lead to debugging confusion if users try to replicate this pattern elsewhere.Fix: Consider clarifying this instruction with one of:
127.0.0.1is the Host header value, not the probe target127.0.0.1as the Inkeep API health endpoint responds regardless of Host header."Refs: