Skip to content
This repository has been archived by the owner on Dec 31, 2022. It is now read-only.

Upgrade to v1.84.2, ColorButton and other functions added #158

Merged
merged 26 commits into from
Sep 29, 2021

Conversation

neclepsio
Copy link
Contributor

Upgrade to v1.84.2.
Added ColorButton.
Copied from scorpheus fork KeyCtrlPressed, GetMouseDragDelta and ResetMouseDragDelta (but without default parameter and without *V variant).
Added KeyShiftPressed, KeyAltPressed, KeySuperPressed.

neclepsio added 23 commits May 18, 2020 11:15
This reverts commit 6b22850.
Merge pull request inkyblackness#111 from neclepsio/fix-minor-typo
KeyCtrlPressed (and wrote similar KeyShiftPressed, KeyAltPressed, KeySuperPressed); GetMouseDragDelta and ResetMouseDragDelta (but without default parameter and without *V variant)
Make ColorButton use Vec4 instead of [4]float32. Add standard drag and drop payloads to let user make ColorButton a drop target for standard color pickers.
@neclepsio
Copy link
Contributor Author

Added BeginDisabled, EndDisabled.

@the-goodies
Copy link
Contributor

There should be an accompanying BeginDisabledV(disabled bool) function, because ImGuis BeginDisabled function takes optional 'disabled' argument. I personally use BeginDisabled(var_which_can_be_false), which I think is quite useful and less error prone than using 'if' before BeginDisabled and EndDisabled to start a disable group. Less error prone because a variable you use with if can change within disabled group block, thus making mismatching calls to Disabled functions.

@dertseha
Copy link
Member

dertseha commented Sep 3, 2021

Hello there and thank you for your patience.
Again, it may take some while until I get to this.
Since new functions are added as well, I might need extra time.
Perhaps I should request version upgrades to be dedicated PRs, though this is a separate thing to ponder...

@neclepsio
Copy link
Contributor Author

Added BeginDisabledV.

Copy link
Member

@dertseha dertseha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience.
I found one minor detail, and I am not convinced to include more BETA APIs. Please comment on that.

Layout.go Show resolved Hide resolved
State.go Outdated Show resolved Hide resolved
Copy link
Member

@dertseha dertseha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!
I prefer to avoid commented code, though I will take it as it is now.

@dertseha dertseha merged commit 8883412 into inkyblackness:main Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants