-
Notifications
You must be signed in to change notification settings - Fork 101
Upgrade to v1.84.2, ColorButton and other functions added #158
Conversation
Sync with upstream
This reverts commit 6b22850.
Fix minor typo
Merge pull request inkyblackness#111 from neclepsio/fix-minor-typo
Sync with upstream
Merge with upstream
KeyCtrlPressed (and wrote similar KeyShiftPressed, KeyAltPressed, KeySuperPressed); GetMouseDragDelta and ResetMouseDragDelta (but without default parameter and without *V variant)
Make ColorButton use Vec4 instead of [4]float32. Add standard drag and drop payloads to let user make ColorButton a drop target for standard color pickers.
Added BeginDisabled, EndDisabled. |
There should be an accompanying BeginDisabledV(disabled bool) function, because ImGuis BeginDisabled function takes optional 'disabled' argument. I personally use BeginDisabled(var_which_can_be_false), which I think is quite useful and less error prone than using 'if' before BeginDisabled and EndDisabled to start a disable group. Less error prone because a variable you use with if can change within disabled group block, thus making mismatching calls to Disabled functions. |
Hello there and thank you for your patience. |
Added BeginDisabledV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience.
I found one minor detail, and I am not convinced to include more BETA APIs. Please comment on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes!
I prefer to avoid commented code, though I will take it as it is now.
Upgrade to v1.84.2.
Added ColorButton.
Copied from scorpheus fork KeyCtrlPressed, GetMouseDragDelta and ResetMouseDragDelta (but without default parameter and without *V variant).
Added KeyShiftPressed, KeyAltPressed, KeySuperPressed.