Skip to content
This repository has been archived by the owner on Dec 31, 2022. It is now read-only.

Combo: Example #177

Merged
merged 6 commits into from
Jun 4, 2022
Merged

Combo: Example #177

merged 6 commits into from
Jun 4, 2022

Conversation

Konstantin8105
Copy link
Contributor

No description provided.

@dertseha dertseha changed the base branch from main to combo June 4, 2022 13:08
@dertseha
Copy link
Member

dertseha commented Jun 4, 2022

Thank you for your contribution - and your patience.
I'm taking over the changeset - there is a small issue: The final parameter (open height in items) should default to -1. Because this PR was sitting so long, I'm handling this.

@dertseha dertseha merged commit 012afed into inkyblackness:combo Jun 4, 2022
@dertseha
Copy link
Member

dertseha commented Jun 4, 2022

PS: I also reverted the name change of the module.
I assume this happened because you forked it and were working in your checked-out fork.
As a future recommendation, I'm passing on this trick:
Next time, when you have done your fork, clone the original repository (e.g. inkyblackness/imgui-go) and then add a second origin repository - that of your fork. This way, the repo is locally available as "inkyblackness/imgui", yet you can work via your branches and changes.

@dertseha dertseha mentioned this pull request Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants