option to disable language autodetect #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlinestyle
reviewed
Jul 23, 2018
test/md-to-react.spec.js
Outdated
| it('should not guess the language when autodetect is false', () => { | ||
| const markdown = '```.test { height: 1em; }```'; | ||
| const wrapper = mount(mdToReact(markdown), { autodetect: false }); | ||
| assert.ok(wrapper.find('code').hasClass('hljs') && wrapper.find('code').hasClass('css')); |
There was a problem hiding this comment.
I could be wrong about this... but isn't this test case the same as the one on line 31 for when it should guess the language? Shouldn't this be different?
There was a problem hiding this comment.
You're right, that test was broken. I fixed it.
|
I'm using this patch; seems to work well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case required this option, so I added it. Test included.