Skip to content

Commit

Permalink
fix group by with null columns
Browse files Browse the repository at this point in the history
takes the relevant part out of
apache#793 which was ignored by
cube maintainers
  • Loading branch information
igorcalabria authored and cfms3 committed May 31, 2024
1 parent 823422f commit 0443692
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion datafusion/src/physical_plan/hash_aggregate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,12 @@ pub(crate) fn create_key(
) -> Result<()> {
vec.clear();
for col in group_by_keys {
create_key_for_col(col, row, vec)?
if !col.is_valid(row) {
vec.push(0xFE);
} else {
vec.push(0xFF);
create_key_for_col(col, row, vec)?
}
}
Ok(())
}
Expand Down

0 comments on commit 0443692

Please sign in to comment.