fix-issue-timedelta #5987
Closed
fix-issue-timedelta #5987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudsjs
requested changes
May 16, 2023
wouterdb
approved these changes
May 16, 2023
arnaudsjs
approved these changes
May 16, 2023
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
May 16, 2023
# Description There seems to be an issue with the _set_timeout function of Tornado. If timeout is a timedelta with value zero it evaluates to false [here](https://github.com/tornadoweb/tornado/blob/master/tornado/queues.py#L62) which causes issues # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [x] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
|
Merged into branches master in f65386c |
inmantaci
pushed a commit
that referenced
this pull request
May 16, 2023
# Description There seems to be an issue with the _set_timeout function of Tornado. If timeout is a timedelta with value zero it evaluates to false [here](https://github.com/tornadoweb/tornado/blob/master/tornado/queues.py#L62) which causes issues # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [ ] Attached issue to pull request - [x] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
|
Processing #5992. |
inmantaci
pushed a commit
that referenced
this pull request
May 16, 2023
Pull request opened by the merge tool on behalf of #5987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There seems to be an issue with the _set_timeout function of Tornado. If timeout is a timedelta with value zero it evaluates to false here which causes issues
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box