Issue/6409 improve language reference documentation #6457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudsjs
requested changes
Sep 5, 2023
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
arnaudsjs
requested changes
Sep 8, 2023
Hugo-Inmanta
commented
Sep 12, 2023
arnaudsjs
requested changes
Sep 12, 2023
Co-authored-by: arnaudsjs <2684622+arnaudsjs@users.noreply.github.com>
Hugo-Inmanta
commented
Sep 12, 2023
Comment on lines
+222
to
+223
| Unlike python's multi-line strings, only double quotes are supported to define a multi-line string i.e. ``"""`` is | ||
| valid, but ``'''`` is not. |
There was a problem hiding this comment.
I was surprised by this
There was a problem hiding this comment.
Yes. Me too. I created a ticket to support this. In the meantime we just document well that single quotes are not supported.
Merged
5 tasks
arnaudsjs
approved these changes
Sep 12, 2023
|
Processing this pull request |
inmantaci
pushed a commit
that referenced
this pull request
Sep 13, 2023
# Description Improve language reference documentation closes #6409 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
|
Merged into branches master in cb0b6b1 |
inmantaci
pushed a commit
that referenced
this pull request
Sep 13, 2023
# Description Improve language reference documentation closes #6409 # Self Check: Strike through any lines that are not applicable (`~~line~~`) then check the box - [x] Attached issue to pull request - [x] Changelog entry - [ ] Type annotations are present - [ ] Code is clear and sufficiently documented - [ ] No (preventable) type errors (check using make mypy or make mypy-diff) - [ ] Sufficient test cases (reproduces the bug/tests the requested feature) - [ ] Correct, in line with design - [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: ) - [ ] If this PR fixes a race condition in the test suite, also push the fix to the relevant stable branche(s) (see [test-fixes](https://internal.inmanta.com/development/core/tasks/build-master.html#test-fixes) for more info)
inmantaci
deleted the
issue/6409-improve-language-reference-documentation
branch
|
Processing #6493. |
inmantaci
pushed a commit
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve language reference documentation
closes #6409
Self Check:
Strike through any lines that are not applicable (
~~line~~) then check the box