Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #334 issue #358

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix #334 issue #358

merged 1 commit into from
Jun 22, 2022

Conversation

SahanY099
Copy link
Contributor

@SahanY099 SahanY099 commented Jun 22, 2022

Description

  • Short description here *

closes Add ticket reference here

Merge procedure

Don't use the github built-in merge, but the process described here

git pull
git checkout master
git pull
git merge --squash issue/{issue-number}-{short description}
inmanta module commit -m "{Commit Message Here}" -r
git push
git push {tag} # push the tag as well

Then close the PR with a reference to the commit

Self Check:

Strike through any lines that are not applicable (~~line~~) then check the box

  • Attached issue to pull request
  • Changelog entry
  • Version number is bumped to dev version
  • Code is clear and sufficiently documented
  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Correct, in line with design
  • End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

  • Sufficient test cases (reproduces the bug/tests the requested feature)
  • Code is clear and sufficiently documented
  • Correct, in line with design

@sanderr
Copy link
Contributor

sanderr commented Jun 22, 2022

Hi @SahanY099. Thank you for your contribution. Normally, we require a contributor license agreement, but because this is a very small change, we can merge it as is.

@sanderr sanderr merged commit 25eee78 into inmanta:master Jun 22, 2022
@SahanY099
Copy link
Contributor Author

@sanderr My pleasure😊.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants