Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move env settings view and expert mode fully to v2 #5999

Open
matborowczyk opened this issue Oct 18, 2024 · 0 comments
Open

Move env settings view and expert mode fully to v2 #5999

matborowczyk opened this issue Oct 18, 2024 · 0 comments

Comments

@matborowczyk
Copy link
Collaborator

currently expert mode is not connected with other queries and disabling it through banner relaying to waiting for that 5s loop,

ExpertBanner would then have to change loading state to isPedning, and query should invalidate adequate queries
@matborowczyk matborowczyk mentioned this issue Oct 18, 2024
Closed
6 tasks
inmantaci pushed a commit that referenced this issue Oct 28, 2024
@matborowczyk @inmantaci
Add button to disable expert mode from the banner (Issue #5942, PR #6000
14147ab 
)

# Description

* Short description here *

https://github.com/user-attachments/assets/ebda2440-4eb9-4ec2-a35e-4540e6752efe

Related task: #5999

closes #5942

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Code is clear and sufficiently documented
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matborowczyk