-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Property does not exist on serve() #340
Comments
Thanks for the report, @ellisio! Sorry you've run into this. A workaround for the moment is to revert the v2 functionality of treating export const { GET, POST, PUT } = serve(...) as any; There's a couple of fixes needed here - one is #339 and the other just needs to be an app router integration test! Let me work on that now. 🙂 |
@jpwilliams Was just in the middle of typing out the |
Should be fixed in 3.0.1 - thank you! |
## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> Fixes #340, ensuring the return type of `"inngest/next"`'s `serve()` is correctly inferred. Fuller integration tests for the app router will come in #341. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~~Added a [docs PR](https://github.com/inngest/website) that references this PR~~ N/A - [ ] ~~Added unit/integration tests~~ N/A #341 - [x] Added changesets if applicable ## Related <!-- A space for any related links, issues, or PRs. --> <!-- Linear issues are autolinked. --> <!-- e.g. - INN-123 --> <!-- GitHub issues/PRs can be linked using shorthand. --> <!-- e.g. "- inngest/inngest#123" --> <!-- Feel free to remove this section if there are no applicable related links.--> - Fixes #340
Describe the bug
When upgrading to v3.0.0, we're getting a typing error:
This is how we have our client defined:
To Reproduce
Steps to reproduce the behavior:
inngest@3.0.0
in a TypeScript NextJS 13 project.functions: []
definition, same thing.Expected behavior
Should not have a typing error.
Code snippets / Logs / Screenshots
System info (please complete the following information):
The text was updated successfully, but these errors were encountered: