Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESM exports to inngest package to avoid extension imports #319

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Sep 20, 2023

Summary

ESM-only frameworks, or at least those that are ESM-first, are becoming more prevalent, meaning we need to add this mapping to ensure users don't need to add file extensions when adding these subpath imports.

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests
  • Added changesets if applicable

Related

ESM-only frameworks, or at least those that are ESM-first, are becoming
more prevalent, meaning we need to add this mapping to ensure users
don't need to add file extensions when adding these subpath imports.
@jpwilliams jpwilliams self-assigned this Sep 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 020042f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams merged commit 71b7d26 into main Sep 20, 2023
@jpwilliams jpwilliams deleted the esm-exports branch September 20, 2023 13:47
jpwilliams pushed a commit that referenced this pull request Sep 21, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## inngest@2.7.0

### Minor Changes

- [#313](#313)
[`32c34b3`](32c34b3)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add ability to
declare and send events without payloads, e.g. `inngest.send({ name:
"my.event" });`

- [#310](#310)
[`696c411`](696c411)
Thanks [@michealroberts](https://github.com/michealroberts)! - Added h3
framework server handler

### Patch Changes

- [#319](#319)
[`71b7d26`](71b7d26)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add ESM exports
to `inngest` package to avoid extension imports

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Did you mean to import inngest/nuxt.js?
3 participants