-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESM exports to inngest
package to avoid extension imports
#319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESM-only frameworks, or at least those that are ESM-first, are becoming more prevalent, meaning we need to add this mapping to ensure users don't need to add file extensions when adding these subpath imports.
🦋 Changeset detectedLatest commit: 020042f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b8b9eb7
to
1fb50e9
Compare
tonyhb
approved these changes
Sep 20, 2023
amh4r
approved these changes
Sep 20, 2023
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Sep 21, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@2.7.0 ### Minor Changes - [#313](#313) [`32c34b3`](32c34b3) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add ability to declare and send events without payloads, e.g. `inngest.send({ name: "my.event" });` - [#310](#310) [`696c411`](696c411) Thanks [@michealroberts](https://github.com/michealroberts)! - Added h3 framework server handler ### Patch Changes - [#319](#319) [`71b7d26`](71b7d26) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add ESM exports to `inngest` package to avoid extension imports Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ESM-only frameworks, or at least those that are ESM-first, are becoming more prevalent, meaning we need to add this mapping to ensure users don't need to add file extensions when adding these subpath imports.
Checklist
Added a docs PR that references this PRN/A Bug fixRelated