Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse .sendEvent() errors from Inngest API (partial of #256) #323

Merged
merged 6 commits into from
Sep 26, 2023

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Sep 25, 2023

Summary

Makes sure we attempt to parse errors from the Inngest API when sending events. Partial of #256.

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests
  • Added changesets if applicable

Related

@jpwilliams jpwilliams requested review from tonyhb and amh4r September 25, 2023 12:06
@jpwilliams jpwilliams self-assigned this Sep 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: 61be33b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams marked this pull request as ready for review September 25, 2023 12:20
Copy link
Contributor

@tonyhb tonyhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is nice.

@jpwilliams jpwilliams merged commit 3b2efa6 into main Sep 26, 2023
@jpwilliams jpwilliams deleted the send-event-error-parsing branch September 26, 2023 09:34
jpwilliams pushed a commit that referenced this pull request Sep 27, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## inngest@2.7.2

### Patch Changes

- [#323](#323)
[`3b2efa6`](3b2efa6)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Better error
handling for `.sendEvent()` errors from Inngest API, ensuring easier
debugging when failing to send events - partial of #256

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants