Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 backcompatibility for V3 #328

Merged
merged 16 commits into from
Oct 2, 2023
Merged

V2 backcompatibility for V3 #328

merged 16 commits into from
Oct 2, 2023

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Sep 26, 2023

Summary

Adds backwards compatibility for in-progress v2.x.x runs for v3.x.x SDKs.

  • Adding x-inngest-req-version header appropriately from response
  • v0.test.ts
  • Lazily importing backwards compatibility N/A Tiny foot-print; can optionally add later

Checklist

  • Added a docs PR that references this PR N/A
  • Added unit/integration tests
  • Added changesets if applicable N/A

Related

@jpwilliams jpwilliams self-assigned this Sep 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

⚠️ No Changeset found

Latest commit: f3b9396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jpwilliams jpwilliams changed the title V2 backcompat V2 backcompatibility for V3 Sep 29, 2023
@jpwilliams jpwilliams marked this pull request as ready for review October 2, 2023 14:19
@jpwilliams jpwilliams merged commit 6486254 into v3-refactor Oct 2, 2023
@jpwilliams jpwilliams deleted the v2-backcompat branch October 2, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant