Fix path matching types getting lost in recursive types #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwilliams
added
Bug
🦋 Changeset detectedLatest commit: 3e516ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A user has added the prerelease/inngest label, so this PR will be published to npm with the tag You can install this prerelease version with: npm install inngest@pr-354The last release was built and published from 3e516ee. |
jpwilliams
force-pushed
the
fix/recursive-types-paths
branch
from
0ee38c6 to
6c60ea5
Compare
jpwilliams
force-pushed
the
fix/recursive-types-paths
branch
from
6c60ea5 to
041dfa0
Compare
tonyhb
approved these changes
Oct 10, 2023
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Oct 10, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.1.1 ### Patch Changes - [#354](#354) [`e2f68d6`](e2f68d6) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix path matching types getting lost in certain recursive event types - [#350](#350) [`933b998`](933b998) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Separate Zod typing from library, enabling minor-agnostic versioning support Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a "Type instantiation is excessively deep and possibly infinite" bug when attempting to generate paths for events with recursive types, such as a common
JsonValuetype.We refactor the way paths are generated a little here, most notably ensuring we skip known deep/recursive types and don't needlessly iterate those we've seen before.
Checklist
Added a docs PR that references this PRN/A Bug fix