Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added framework-nestjs example with dependency injection into inggest function #387

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

anasabdullahysfzai
Copy link
Contributor

Summary

Added framework-nestjs example with dependency injection into inggest function. Existing example doesnt mention about injecting dependency in inngest function thats why we added a logic to do so.

Copy link

changeset-bot bot commented Nov 8, 2023

⚠️ No Changeset found

Latest commit: 6826687

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@anasabdullahysfzai
Copy link
Contributor Author

@jpwilliams can you please review this PR

@jpwilliams jpwilliams self-assigned this Nov 8, 2023
Copy link
Member

@jpwilliams jpwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, @anasabdullahysfzai.

I'd love to also get an example going with nest-inngest (thawankeane/nest-inngest) later.

I've made it slightly more generic in a few places and we can improve as we go. Thanks so much for the contribution! 🙌

@jpwilliams jpwilliams merged commit b65c024 into inngest:main Nov 8, 2023
21 of 22 checks passed
@anasabdullahysfzai
Copy link
Contributor Author

Awesome! Thanks, @anasabdullahysfzai.

I'd love to also get an example going with nest-inngest (thawankeane/nest-inngest) later.

I've made it slightly more generic in a few places and we can improve as we go. Thanks so much for the contribution! 🙌

Thanks Jack. I havent yet checked nest-inggest myself. I will create its example once i have checked it out. Also I loved the idea behind inggest. I think this project should be promoted more often. Are there any plans to do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants