Fix broken debug extension
#631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87a378c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jpwilliams
added
the
prerelease/inngest
|
A user has added the prerelease/inngest label, so this PR will be published to npm with the tag You can install this prerelease version with: npm install inngest@pr-631The last release was built and published from 87a378c. |
Merged
jpwilliams
added a commit
that referenced
this pull request
Jul 2, 2024
## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> [debug](https://www.npmjs.com/package/debug) is a really old library, and its browser detection is old, too. For newer pairings of framework and runtime such as Nitro + Cloudflare Pages, their code for detecting which code should be delivered doesn't catch the markers these leave behind. One silly symptom of this is that `Debug()` returns an anonymous function with no extra properties instead of a `Debugger` instance if the wrong code is consumed following a bad detection. This results in the following `.extend()` call failing. We fix that here by just not calling `.extend()`. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~Added a [docs PR](https://github.com/inngest/website) that references this PR~ N/A Bug fix - [ ] ~Added unit/integration tests~ N/A Will add a Nitro example in another PR - [x] Added changesets if applicable
jpwilliams
pushed a commit
that referenced
this pull request
Jul 2, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.19.19 ### Patch Changes - [#631](#631) [`ac6796c`](ac6796c) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix exception being thrown from `debug` when used with Nitro running on Cloudflare Pages - [`191fe36`](191fe36) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix failure handlers incorrectly inheriting config options such as `batchEvents` and `concurrency` from their parent function - [#630](#630) [`d4de6d7`](d4de6d7) Thanks [@stefanosala](https://github.com/stefanosala)! - Fix missing config fields such as `concurrency` when validating Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jpwilliams
added a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
debug is a really old library, and its browser detection is old, too. For newer pairings of framework and runtime such as Nitro + Cloudflare Pages, their code for detecting which code should be delivered doesn't catch the markers these leave behind.
One silly symptom of this is that
Debug()returns an anonymous function with no extra properties instead of aDebuggerinstance if the wrong code is consumed following a bad detection. This results in the following.extend()call failing.We fix that here by just not calling
.extend().Checklist
Added a docs PR that references this PRN/A Bug fixAdded unit/integration testsN/A Will add a Nitro example in another PR